Message 271787 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	belopolsky
Recipients	SilentGhost, belopolsky
Date	2016-08-01.16:00:27
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1470067227.57.0.335288543873.issue27661@psf.upfronthosting.co.za>
In-reply-to

Content
From review comments: Lib/datetime.py:1482: def combine(cls, date, time, tzinfo=True): On 2016/08/01 08:47:14, SilentGhost wrote: > This strikes me as an odd default value, why not use a more conventional None? This is the same default as used in the .replace() methods. Arguably, a proper sentinel value would be a better choice, but I think True delivers better performance. In any case, this is not something I would change without consulting with the PyPy folks. See <http://bugs.python.org/review/27661/diff/18026/Lib/datetime.py#newcode1482>.

From review comments:

Lib/datetime.py:1482: def combine(cls, date, time, tzinfo=True):
On 2016/08/01 08:47:14, SilentGhost wrote:
> This strikes me as an odd default value, why not use a more conventional None?

This is the same default as used in the .replace() methods.  Arguably, a proper sentinel value would be a better choice, but I think True delivers better performance.  In any case, this is not something I would change without consulting with the PyPy folks.

See <http://bugs.python.org/review/27661/diff/18026/Lib/datetime.py#newcode1482>.

History
Date	User	Action	Args
2016-08-01 16:00:27	belopolsky	set	recipients: + belopolsky, SilentGhost
2016-08-01 16:00:27	belopolsky	set	messageid: <1470067227.57.0.335288543873.issue27661@psf.upfronthosting.co.za>
2016-08-01 16:00:27	belopolsky	link	issue27661 messages
2016-08-01 16:00:27	belopolsky	create