➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author martin.panter
Recipients BreamoreBoy, martin.panter, rpetrov
Date 2016-07-27.06:16:31
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1469600192.12.0.219133790162.issue17594@psf.upfronthosting.co.za>
In-reply-to
Content 
Interesting approach. Why two separate files, for cross-compiling and native compiling? Why not merge them together?

Some of the other Min GW patches add stuff like the following to the configure.ac checks. Would it make more sense to add e.g. ac_cv_struct_addrinfo=yes to the config, and avoid the compile check?

 AC_CACHE_VAL(ac_cv_struct_addrinfo,
-AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[#include <netdb.h>]], [[struct addrinfo a]])],
+AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[
+#ifdef HAVE_WS2TCPIP_H
+#  include <ws2tcpip.h>
+#else
+#  include <netdb.h>
+#endif]],
+    [[struct addrinfo a]])],
   [ac_cv_struct_addrinfo=yes],
   [ac_cv_struct_addrinfo=no]))
History
Date User Action Args
2016-07-27 06:16:32martin.pantersetrecipients: + martin.panter, rpetrov, BreamoreBoy
2016-07-27 06:16:32martin.pantersetmessageid: <1469600192.12.0.219133790162.issue17594@psf.upfronthosting.co.za>
2016-07-27 06:16:32martin.panterlinkissue17594 messages
2016-07-27 06:16:31martin.pantercreate