Message270586
The approaches look good, but for clarity I want to replace all method calls that should never be overridden by the plain C functions of their corresponding static types.
I have no opinion about the Python version. The diff also "fixes" #26975 for the C version, so perhaps the Python version should be in sync. It is an academic question, since no one will write a class that triggers it.
Preemptively, I'm aware that long_bit_length() is defined with a single argument, then cast to a CFunction, then called with two arguments.
ceval.c does the same. -- We had a discussion about that with MvL a while ago, he preferred to define all CFunctions with two arguments. I'd also prefer that, but that is another issue. |
|
Date |
User |
Action |
Args |
2016-07-16 22:09:29 | skrah | set | recipients:
+ skrah, rhettinger, facundobatista, mark.dickinson, serhiy.storchaka |
2016-07-16 22:09:28 | skrah | set | messageid: <1468706968.98.0.589076272708.issue26974@psf.upfronthosting.co.za> |
2016-07-16 22:09:28 | skrah | link | issue26974 messages |
2016-07-16 22:09:28 | skrah | create | |
|