Message270354
Thanks for your comment Martin. I'll apply them later when we reach agreement on functions.
I have already used object = NULL, the C default is not necessary here, and it works as you like I think. In patch version 1, b'abc'.translate(None, None) raises exception as before. I change it in patch version 2 because argument clinic generates function signature as "($self, table, /, delete=None)". So I don't want users get surprised when they provide None as the signature but get an exception. And using None as a placeholder for a keyword argument is normal in Python. But I'm OK to keep the previous behaviour and actually I prefer that.
As for making the first argument optional, I don't quite like that since the doc seems to encourage users to set None explicitly. |
|
Date |
User |
Action |
Args |
2016-07-14 02:52:27 | xiang.zhang | set | recipients:
+ xiang.zhang, r.david.murray, martin.panter, serhiy.storchaka |
2016-07-14 02:52:27 | xiang.zhang | set | messageid: <1468464747.63.0.71673246606.issue27506@psf.upfronthosting.co.za> |
2016-07-14 02:52:27 | xiang.zhang | link | issue27506 messages |
2016-07-14 02:52:27 | xiang.zhang | create | |
|