This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author abarry
Recipients abarry, martin.panter
Date 2016-04-19.03:00:57
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1461034857.48.0.0658258576179.issue26801@psf.upfronthosting.co.za>
In-reply-to
Content
I think Rietveld doesn't like me because I made it a .diff file, and not a .patch file, but who knows.

It's a bit of a shot in the dark though, because I can't reproduce an environment where `os.get_terminal_size()` doesn't exist. I'm on Windows and sometimes compile the latest trunk to play around and find bugs, so it could be in one of those times (even though I just tried and it didn't fail).

I think that if `NameError` was to be caught before, it means the function was to be "maybe there, maybe not", which could very well still be the case, so it makes sense to use the proper exception in that case. I don't see any significant drawback to catching AttributeError, anyway.
History
Date User Action Args
2016-04-19 03:00:57abarrysetrecipients: + abarry, martin.panter
2016-04-19 03:00:57abarrysetmessageid: <1461034857.48.0.0658258576179.issue26801@psf.upfronthosting.co.za>
2016-04-19 03:00:57abarrylinkissue26801 messages
2016-04-19 03:00:57abarrycreate