Message262944
Nice.
> I discovered a flaw in the bytearray tests: most of them don’t actually test bytearray objects!
Good catch!
> I adapted the tests from the deleted buffer_tests.py file to override the relevant tests from string_tests.py, so that we continue to test bytearray methods but with str a.k.a. bytes arguments.
The patch LGTM. But may be instead of duplicating tests add fixfillchartype() (calling fixtype() by default)? If this don't complicate tests too much. |
|
Date |
User |
Action |
Args |
2016-04-06 13:32:45 | serhiy.storchaka | set | recipients:
+ serhiy.storchaka, ezio.melotti, martin.panter |
2016-04-06 13:32:45 | serhiy.storchaka | set | messageid: <1459949565.39.0.583869625709.issue26257@psf.upfronthosting.co.za> |
2016-04-06 13:32:45 | serhiy.storchaka | link | issue26257 messages |
2016-04-06 13:32:45 | serhiy.storchaka | create | |
|