This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author serhiy.storchaka
Recipients ezio.melotti, martin.panter, serhiy.storchaka
Date 2016-04-06.13:32:45
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1459949565.39.0.583869625709.issue26257@psf.upfronthosting.co.za>
In-reply-to
Content
Nice.

> I discovered a flaw in the bytearray tests: most of them don’t actually test bytearray objects!

Good catch!

> I adapted the tests from the deleted buffer_tests.py file to override the relevant tests from string_tests.py, so that we continue to test bytearray methods but with str a.k.a. bytes arguments.

The patch LGTM. But may be instead of duplicating tests add fixfillchartype() (calling fixtype() by default)? If this don't complicate tests too much.
History
Date User Action Args
2016-04-06 13:32:45serhiy.storchakasetrecipients: + serhiy.storchaka, ezio.melotti, martin.panter
2016-04-06 13:32:45serhiy.storchakasetmessageid: <1459949565.39.0.583869625709.issue26257@psf.upfronthosting.co.za>
2016-04-06 13:32:45serhiy.storchakalinkissue26257 messages
2016-04-06 13:32:45serhiy.storchakacreate