This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author eryksun
Recipients eryksun, jkloth, paul.moore, steve.dower, tim.golden, vstinner, zach.ware
Date 2016-03-31.05:47:19
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1459403240.13.0.18084492332.issue26658@psf.upfronthosting.co.za>
In-reply-to
Content
I don't disagree with using os.path.lexists. However, I think it should also use a temporary target directory. Also, if it's possible to fix the behavior of os.stat when GetFinalPathNameByHandle fails (considering we already have a handle for the target), then that's icing on the cake. 

Another issue related to leaving garbage behind is when the DeviceIoControl call fails to store the reparse point. In this case, _winapi.CreateJunction fails to remove the directory that it creates for the junction. That should be fixed and tested. If CreateJunction fails with ERROR_INVALID_FUNCTION, test_create_junction should be modified to fail only if self.junction still exists. Otherwise the test should pass, i.e. it worked correctly by raising an exception and cleaning up after itself given a filesystem that doesn't support junctions.
History
Date User Action Args
2016-03-31 05:47:20eryksunsetrecipients: + eryksun, paul.moore, vstinner, tim.golden, jkloth, zach.ware, steve.dower
2016-03-31 05:47:20eryksunsetmessageid: <1459403240.13.0.18084492332.issue26658@psf.upfronthosting.co.za>
2016-03-31 05:47:20eryksunlinkissue26658 messages
2016-03-31 05:47:19eryksuncreate