This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author martin.panter
Recipients martin.panter, vstinner
Date 2016-03-24.01:06:22
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1458781583.07.0.204974449954.issue26612@psf.upfronthosting.co.za>
In-reply-to
Content
My point about Python 2 was that this might add an annoying difference between the two branches. Even if you don’t apply this to Py 2, the next person adding or updating a test might be inclined to do it.

Looking closer at your patch I admit that addCleanup() wouldn’t be appropriate except for the first change.

Maybe it would be okay to leave the “try / finally” cases as they are? Moving connect() inside is good though IMO.

Anyway, I’m only mildly against this. I don’t see much benefit, but I could tolerate the downsides. I guess it’s up to you.
History
Date User Action Args
2016-03-24 01:06:23martin.pantersetrecipients: + martin.panter, vstinner
2016-03-24 01:06:23martin.pantersetmessageid: <1458781583.07.0.204974449954.issue26612@psf.upfronthosting.co.za>
2016-03-24 01:06:23martin.panterlinkissue26612 messages
2016-03-24 01:06:22martin.pantercreate