Message262246
Martin Panter added the comment:
> Wouldn’t it be better to fix the underlying problem with the test cases?
I don't feel able to fix AIX issues, and I don't think that we can fix
all issues. You still get ResourceWarning if you interrupt the test
with CTRL+c which is not a bug.
> Also, you can often use self.addCleanup(s.close), which saves a level of indentation (and associated noise in the annotate history).
It may work on some cases, but not all of them. And I like controlling
when a socket is closed: I prefer to close it inside the test, and not
sometime later with unittest magic features.
> Also remember that sockets don’t do context management in Python 2, so this would bring more incompatibilies when merging tests between the two branches.
Since this issue is not really a blocker bug, I suggest to only modify
Python 3.6.
It's a follow-up of all work on ResourceWarning (on Python 3.6) last days:
https://docs.python.org/dev/whatsnew/3.6.html#warnings |
|
Date |
User |
Action |
Args |
2016-03-23 08:02:05 | vstinner | set | recipients:
+ vstinner, martin.panter |
2016-03-23 08:02:05 | vstinner | link | issue26612 messages |
2016-03-23 08:02:04 | vstinner | create | |
|