Message260641
Thankyou Jelte for finding this. We made RemoteDisconnected inherit from ConnectionResetError (and therefore OSError) thinking it would help with compatibility, but in this case that has backfired. Your patch looks like a valid fix.
I would like to figure out a concise way to produce the fault so I can add a test case and play with the code. Would I be able to use Python’s XML-RPC server, or would I have to make a custom server that dropped the connection?
Also I suspect both exception handlers in the XML-RPC client could be combined as “except ConnectionError”, but I want to be sure before making that change. |
|
Date |
User |
Action |
Args |
2016-02-21 21:25:31 | martin.panter | set | recipients:
+ martin.panter, SilentGhost, JelteF |
2016-02-21 21:25:31 | martin.panter | set | messageid: <1456089931.75.0.578521627171.issue26402@psf.upfronthosting.co.za> |
2016-02-21 21:25:31 | martin.panter | link | issue26402 messages |
2016-02-21 21:25:31 | martin.panter | create | |
|