Message260532
I thought the purpose of server_close() was to clean up resources after you have finished calling serve_forever() or handle_request(). Just like you call close() on a file after you have finished reading or writing it. If you try to read or write a closed file, that is a programmer error.
This proposal sounds like a new feature, but you are overloading or redefining the purpose of server_close().
From the test case I presume you intend to use server_close() in a separate thread from the thread running serve_forever(). But closing a file descriptor while it is being used in another thread does not seem robust to me. It could cause serve_forever() to raise EBADF. In the worst case, consider what happens if an unrelated third thread makes the server’s file descriptor valid again by opening a file.
What is your use case? If you want to use multithreading, why can’t you use the shutdown() method? For a single-threaded server, maybe see Issue 13749, and maybe Issue 23430 would help by allowing exceptions like SystemExit to stop the server. |
|
Date |
User |
Action |
Args |
2016-02-19 22:41:39 | martin.panter | set | recipients:
+ martin.panter, palaviv |
2016-02-19 22:41:38 | martin.panter | set | messageid: <1455921698.98.0.562564478128.issue26392@psf.upfronthosting.co.za> |
2016-02-19 22:41:38 | martin.panter | link | issue26392 messages |
2016-02-19 22:41:38 | martin.panter | create | |
|