Message260488
> I can see the advantage of using an enum over a plain string. But you only get an error at run time, not compile time, if you misspell it.
Sure, but at least you're giving static analysis utilities the chance to catch it up front.
> And there is also the disadvantage of the extra boilerplate of importing HTTPMessage.
I guess that all depends on how you're importing your modules. If you just import "http", then there's no additional boilerplate.
> So I don’t have a strong opinion either way. Do other libraries have a similar enum?
I haven't seen enums in other libraries, only constants. I figured that it might as well be consistent with HTTPStatus, although granted, HTTPStatus does a little more than the methods. |
|
Date |
User |
Action |
Args |
2016-02-18 23:49:36 | demian.brecht | set | recipients:
+ demian.brecht, r.david.murray, ethan.furman, martin.panter |
2016-02-18 23:49:36 | demian.brecht | set | messageid: <1455839376.05.0.26440647337.issue26380@psf.upfronthosting.co.za> |
2016-02-18 23:49:36 | demian.brecht | link | issue26380 messages |
2016-02-18 23:49:35 | demian.brecht | create | |
|