Message 260336 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	deronnax
Recipients	deronnax, martin.panter, spaceone
Date	2016-02-15.22:47:41
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1455576461.36.0.418486916392.issue25738@psf.upfronthosting.co.za>
In-reply-to

Content
I was looking at this issue, and actually the problem is on a different level. The function the patch takes place is "send_errror". As its name suggests, it's only used to send error (I checked in the code : it's only used to send 4XX/5XX reply). I'm sure none of this reply forbid to carry a body. So I think the whole "if code >= 200 and code >= 200 and code not in (code not in (HTTPStatus.NO_CONTENT, HTTPStatus.NOT_MODIFIED)):" should just be replaced by a assert 400 <= code < 600. And more seriously : who could be using this code for a modern real world usage ? Why not delete it ? Isn't it harmful that unwarned might use it ?

I was looking at this issue, and actually the problem is on a different level.
The function the patch takes place is "send_errror". As its name suggests, it's only used to send error (I checked in the code : it's only used to send 4XX/5XX reply). I'm sure none of this reply forbid to carry a body.
So I think the whole "if code >= 200 and code >= 200 and                   code not in (code not in (HTTPStatus.NO_CONTENT, HTTPStatus.NOT_MODIFIED)):" should just be replaced by a assert 400 <= code < 600.

And more seriously : who could be using this code for a modern real world usage ? Why not delete it ? Isn't it harmful that unwarned might use it ?

History
Date	User	Action	Args
2016-02-15 22:47:41	deronnax	set	recipients: + deronnax, martin.panter, spaceone
2016-02-15 22:47:41	deronnax	set	messageid: <1455576461.36.0.418486916392.issue25738@psf.upfronthosting.co.za>
2016-02-15 22:47:41	deronnax	link	issue25738 messages
2016-02-15 22:47:41	deronnax	create