➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author benjamin.peterson
Recipients barry, benjamin.peterson, doko, martin.panter, serhiy.storchaka
Date 2016-02-08.06:34:33
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1454913270.2435062.514779010.2C32643D@webmail.messagingengine.com>
In-reply-to <1454883823.39.0.654198849609.issue25698@psf.upfronthosting.co.za>
Content 
I don't think this patch is the best way. The correct way is to have and
use PyDict_GetWithError. I wouldn't be surprised if you could crash
Python under this patch by putting some function with an import in
__cmp__ in sys.modules.

On Sun, Feb 7, 2016, at 14:23, Serhiy Storchaka wrote:
> 
> Serhiy Storchaka added the comment:
> 
> Benjamin, could you please make a review?
> 
> ----------
> 
> _______________________________________
> Python tracker <report@bugs.python.org>
> <http://bugs.python.org/issue25698>
> _______________________________________
History
Date User Action Args
2016-02-08 06:34:34benjamin.petersonsetrecipients: + benjamin.peterson, barry, doko, martin.panter, serhiy.storchaka
2016-02-08 06:34:34benjamin.petersonlinkissue25698 messages
2016-02-08 06:34:33benjamin.petersoncreate