Message259750
_LegalChars contained only characters which don't require quoting, as documented in the comment above. If _LegalChars was only used to create _is_legal_key, we would just wrote the regular expression. But it is used also in other places. In this particular case adding "\" to _LegalChars doesn't lead to visible bug (except inconsistency with the comment), but we can't be sure.
_is_legal_key() is implementation detail. It would be better to test public API. |
|
Date |
User |
Action |
Args |
2016-02-06 20:24:48 | serhiy.storchaka | set | recipients:
+ serhiy.storchaka, jaraco, demian.brecht, anish.shah, Kunal Grover |
2016-02-06 20:24:48 | serhiy.storchaka | set | messageid: <1454790288.64.0.0551095174746.issue26302@psf.upfronthosting.co.za> |
2016-02-06 20:24:48 | serhiy.storchaka | link | issue26302 messages |
2016-02-06 20:24:48 | serhiy.storchaka | create | |
|