Message257494
I’m sorry I only read your patch and did not see the NoLen class above Blocked. (I blame the lack of Reitveld review link.) I still think __getitem__() should have a valid signature, but I acknowledge that it’s not really your fault. :)
My main concern about the documentation was that in your patch you say _all_ special methods are now allowed to be None, but in your code you only check __iter__(). This is adding new undocumented inconsistencies e.g. with Iterable vs Container. Maybe it would be better to only say that setting __iter__ to None is supported, instead of setting any special method. |
|
Date |
User |
Action |
Args |
2016-01-04 21:25:15 | martin.panter | set | recipients:
+ martin.panter, gvanrossum, rhettinger, terry.reedy, ncoghlan, r.david.murray, serhiy.storchaka, abarnert, abarry, curioswati |
2016-01-04 21:25:15 | martin.panter | set | messageid: <1451942715.85.0.823882047666.issue25864@psf.upfronthosting.co.za> |
2016-01-04 21:25:15 | martin.panter | link | issue25864 messages |
2016-01-04 21:25:15 | martin.panter | create | |
|