This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author kovidgoyal
Recipients kovidgoyal, paul.moore, steve.dower, tim.golden, zach.ware
Date 2015-11-29.13:26:31
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1448803591.65.0.187948795392.issue25759@psf.upfronthosting.co.za>
In-reply-to
Content
I missed a few places in my initial patch, updated patch:
https://github.com/kovidgoyal/cpython/commit/a9ec814d466d3c0139d10b69666f88eed10e4940

Also fixed the code not clearing errno before calling CRT functions, while I was there. Regardless of whether you want to allow your fork to be compiled with VS 2015 or not, I suggest you consider merging this patch, anyway, since the errno clearing is the correct thing to do, regardless. You can always cherrypick the errno clearing bits if you like :)

Just FYI, the code in my fork of 2.7 passes all tests on 64bit builds with VS 2015, except for 5 small ones that I have yet to track down. (test_ctypes test_distutils test_gzip test_mailbox test_zipfile)

I dont anticipate any difficulty in fixing the remaining test failures. Famous last words ;)
History
Date User Action Args
2015-11-29 13:26:31kovidgoyalsetrecipients: + kovidgoyal, paul.moore, tim.golden, zach.ware, steve.dower
2015-11-29 13:26:31kovidgoyalsetmessageid: <1448803591.65.0.187948795392.issue25759@psf.upfronthosting.co.za>
2015-11-29 13:26:31kovidgoyallinkissue25759 messages
2015-11-29 13:26:31kovidgoyalcreate