Message 255563 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	kovidgoyal
Recipients	kovidgoyal, paul.moore, steve.dower, tim.golden, zach.ware
Date	2015-11-29.06:49:51
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1448779792.26.0.43379916745.issue25759@psf.upfronthosting.co.za>
In-reply-to

Content
I have it building with just two simple patches: https://github.com/kovidgoyal/cpython/commit/fd1ceca4f21135f12ceb72f37d4ac5ea1576594d https://github.com/kovidgoyal/cpython/commit/edb740218c04b38aa0f385188103100a972d608c However, in developing the patches, I discovered what looks like a bug in the CRT close() function. If you double close a valid file descriptor it crashes, rather than calling the invalid parameter handler. python -c "import os; os.close(2); os.close(2)" crashes. This is true for python 2.7.10 built against VS 2008 as well. This contrasts with the behavior of double close() on other operating systems, where it sets errno to EBADF and does not crash. I have not tested it with python 3.5, but I assume the bug is present there as well.

I have it building with just two simple patches:

https://github.com/kovidgoyal/cpython/commit/fd1ceca4f21135f12ceb72f37d4ac5ea1576594d

https://github.com/kovidgoyal/cpython/commit/edb740218c04b38aa0f385188103100a972d608c

However, in developing the patches, I discovered what looks like a bug in the CRT close() function. If you double close a valid file descriptor it crashes, rather than calling the invalid parameter handler.

python -c "import os; os.close(2); os.close(2)"

crashes. This is true for python 2.7.10 built against VS 2008 as well. This contrasts with the behavior of double close() on other operating systems, where it sets errno to EBADF and does not crash.

I have not tested it with python 3.5, but I assume the bug is present there as well.

History
Date	User	Action	Args
2015-11-29 06:49:52	kovidgoyal	set	recipients: + kovidgoyal, paul.moore, tim.golden, zach.ware, steve.dower
2015-11-29 06:49:52	kovidgoyal	set	messageid: <1448779792.26.0.43379916745.issue25759@psf.upfronthosting.co.za>
2015-11-29 06:49:52	kovidgoyal	link	issue25759 messages
2015-11-29 06:49:51	kovidgoyal	create