Message255361
# https://hg.python.org/cpython/file/tip/Lib/fnmatch.py
fnmatch reviewing the code I've noticed that the outcome of the regular expression all returns generated in the first result
l97:
res = res + '.*'
to:
res = res + '.*?'
l100:
return res + '\Z(?ms)'
to:
return res + '$(?ms)'
example test:
import re
import fnmatch
urls = ['example/l1/l2/test3-1.py',
'example/l1/test2-1.py',
'example/l1/test2-2.py',
'example/l1/l2/l3/test4-1.py']
regex = fnmatch.translate('example/*')
# 'example\\/.*\\Z(?ms)'
re.findall(regex, "\n".join(urls))
# return ['example/l1/l2/test3-1.py\nexample/l1/test2-1.py\nexample/l1/test2-2.py\nexample/l1/l2/l3/test4-1.py']
# suggested change
re.findall('example\\/.*?$(?ms)', "\n".join(urls))
# return ['example/l1/l2/test3-1.py',
# 'example/l1/test2-1.py',
# 'example/l1/test2-2.py',
# 'example/l1/l2/l3/test4-1.py'] |
|
Date |
User |
Action |
Args |
2015-11-25 14:43:46 | Alberto Galera | set | recipients:
+ Alberto Galera |
2015-11-25 14:43:46 | Alberto Galera | set | messageid: <1448462626.73.0.555480375618.issue25734@psf.upfronthosting.co.za> |
2015-11-25 14:43:46 | Alberto Galera | link | issue25734 messages |
2015-11-25 14:43:46 | Alberto Galera | create | |
|