Message 254102 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	vstinner
Recipients	benjamin.peterson, rhettinger, serhiy.storchaka, vstinner
Date	2015-11-05.11:49:17
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1446724157.6.0.97424935894.issue25557@psf.upfronthosting.co.za>
In-reply-to

Content
> When LOAD_NAME is generated? Is it worth to optimize this case? Aren't LOAD_FAST and LOAD_GLOBAL used in performance critical code? I guess that it's only used to execute the body of modules. > Is it worth to optimize this case? Hum, I don't know :-) > It looks to me that there is a bug in fast path of _PyDict_LoadGlobal. If the first lookup fails, it can raise an exception. Sorry, where exactly? Can you maybe put a comment on the review? I see many checks to handle errors.

> When LOAD_NAME is generated? Is it worth to optimize this case? Aren't LOAD_FAST and LOAD_GLOBAL used in performance critical code?

I guess that it's only used to execute the body of modules.

> Is it worth to optimize this case?

Hum, I don't know :-)

> It looks to me that there is a bug in fast path of _PyDict_LoadGlobal. If the first lookup fails, it can raise an exception.

Sorry, where exactly? Can you maybe put a comment on the review? I see many checks to handle errors.

History
Date	User	Action	Args
2015-11-05 11:49:17	vstinner	set	recipients: + vstinner, rhettinger, benjamin.peterson, serhiy.storchaka
2015-11-05 11:49:17	vstinner	set	messageid: <1446724157.6.0.97424935894.issue25557@psf.upfronthosting.co.za>
2015-11-05 11:49:17	vstinner	link	issue25557 messages
2015-11-05 11:49:17	vstinner	create