Message254094
Attached patch adds assertions to PyObject_GetItem() to ensure that an exception is raised if the function failed. _Py_CheckFunctionResult() could be used to implement such check, but it might adds a little overhead, whereas I really don't think that such bug occurs in the wild. The assertion only helps when you develop a new custom type implementing the mapping API.
The patch also simplifies Python/ceval.c: it now considers that an exception is raised if PyObject_GetItem() returns NULL.
Finally, the patch also fixes a bug in the LOAD_NAME bytecode, when globals are not a dict but a custom type and the name doesn't exist in globals: clear the exception before calling PyObject_GetItem() on builtins. |
|
Date |
User |
Action |
Args |
2015-11-05 09:52:03 | vstinner | set | recipients:
+ vstinner, serhiy.storchaka |
2015-11-05 09:52:03 | vstinner | set | messageid: <1446717123.25.0.590354154492.issue25556@psf.upfronthosting.co.za> |
2015-11-05 09:52:03 | vstinner | link | issue25556 messages |
2015-11-05 09:52:02 | vstinner | create | |
|