Message254030
FWIW I don’t see it as a drastic change. If the current patch for Issue 12029 went ahead, I imagine the change for instance checking could look like
@@ PyErr_GivenExceptionMatches()
- /* err might be an instance, so check its class. */
- if (PyExceptionInstance_Check(err))
- err = PyExceptionInstance_Class(err);
@@ given_exception_matches_inner()
- res = PyObject_IsSubclass(err, exc);
+ if (PyExceptionInstance_Check(err)) {
+ res = PyObject_IsInstance(err, exc);
+ } else {
+ res = PyObject_IsSubclass(err, exc);
+ } |
|
Date |
User |
Action |
Args |
2015-11-03 23:39:19 | martin.panter | set | recipients:
+ martin.panter, r.david.murray, sjoerdjob |
2015-11-03 23:39:19 | martin.panter | set | messageid: <1446593959.0.0.755326424437.issue25537@psf.upfronthosting.co.za> |
2015-11-03 23:39:18 | martin.panter | link | issue25537 messages |
2015-11-03 23:39:18 | martin.panter | create | |
|