This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author vxgmichel
Recipients Yury.Selivanov, gvanrossum, python-dev, r.david.murray, vstinner, vxgmichel, yselivanov
Date 2015-10-05.16:50:42
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1444063842.9.0.00175516982773.issue25304@psf.upfronthosting.co.za>
In-reply-to
Content
> The docs look good.

Should I add a note to explain why the loop argument has to be explicitly passed? (there is a note at the beginning of the `task functions` section stating "In the functions below, the optional loop argument ...")

> What do you need to add to the concurrency and multithreading section?

This section provides an example to schedule a coroutine from a different thread using `ensure_future` and `call_soon_threadsafe`. This example should be replaced with another usage of `call_soon_threadsafe` and another paragraph about `run_coroutine_threadsafe` should be added.

> I agree on the try/except

Do you think the exception should be re-raised for the logger?

> can you add that to the same diff? 

All right, should I make another PR on the asyncio github repo as well?
History
Date User Action Args
2015-10-05 16:50:42vxgmichelsetrecipients: + vxgmichel, gvanrossum, vstinner, r.david.murray, Yury.Selivanov, python-dev, yselivanov
2015-10-05 16:50:42vxgmichelsetmessageid: <1444063842.9.0.00175516982773.issue25304@psf.upfronthosting.co.za>
2015-10-05 16:50:42vxgmichellinkissue25304 messages
2015-10-05 16:50:42vxgmichelcreate