This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author martin.panter
Recipients Thomas Güttler, ethan.furman, guettli, lars.gustaebel, martin.panter
Date 2015-06-21.08:55:36
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1434876937.08.0.824254976223.issue24259@psf.upfronthosting.co.za>
In-reply-to
Content
From the current documentation and limited experience with the module, ReadError (or a subclass) sounds best. I would only expect OSError only for OS-level things, like file not found, disk error, etc.

The patches look good. One last suggestion is to use assertRaisesRegex, to be sure that you are getting exactly the exception you expect. Too many times I have found tests in the test suite that were completely broken, but happened to pass because the error happened to match the exception being tested.
History
Date User Action Args
2015-06-21 08:55:37martin.pantersetrecipients: + martin.panter, guettli, lars.gustaebel, ethan.furman, Thomas Güttler
2015-06-21 08:55:37martin.pantersetmessageid: <1434876937.08.0.824254976223.issue24259@psf.upfronthosting.co.za>
2015-06-21 08:55:37martin.panterlinkissue24259 messages
2015-06-21 08:55:36martin.pantercreate