Message242110
To react to myself: checking for self.dict_type might break users that pass in a callable:
x = plistlib.load(fp, dict_type=lambda:{})
As Behdad memtioned testing that the type isn't list would be better:
if not isinstance(..., list):
That attached patch adds a testcase and removes replaces the test for type({}) for something better.
Note: it also replaces ``type([])`` with ``list``, the latter is cleaner. |
|
Date |
User |
Action |
Args |
2015-04-27 11:02:07 | ronaldoussoren | set | recipients:
+ ronaldoussoren, ned.deily, Behdad.Esfahbod |
2015-04-27 11:02:07 | ronaldoussoren | set | messageid: <1430132527.48.0.989196994064.issue24040@psf.upfronthosting.co.za> |
2015-04-27 11:02:07 | ronaldoussoren | link | issue24040 messages |
2015-04-27 11:02:07 | ronaldoussoren | create | |
|