Message241985
> I've updated the patch with the comments from the review
Thanks William for your contribution, I commited your fix.
I just made a minor change on "if (cwd && use_bytes) {": you forgot to remove test now useless test on cwd, and I dropped { and } to make to short more readable (Note: the PEP 7 requires to put "}" and "else {" on two lines).
Ok, I just took 5 years to get Python 2 features in Python 3 :-) |
|
Date |
User |
Action |
Args |
2015-04-24 22:26:40 | vstinner | set | recipients:
+ vstinner, loewis, terry.reedy, pitrou, giampaolo.rodola, boya, santoso.wijaya, python-dev, zach.ware, serhiy.storchaka, worr |
2015-04-24 22:26:40 | vstinner | set | messageid: <1429914400.15.0.868795997397.issue9246@psf.upfronthosting.co.za> |
2015-04-24 22:26:40 | vstinner | link | issue9246 messages |
2015-04-24 22:26:39 | vstinner | create | |
|