Message241900
Here's a new version of Georg's patch which applies to the current default branch. On my OSX 10.8, CPython compiles fine and all tests pass, though test_devpoll and test_epoll were skipped.
I haven't made additional changes, so there is still AC-related work to be done here. For example, there are legacy converters used throughout the code, which should be replaced.
Changes I had to make to get this working:
1)
Updated the class declarations in selectmodule.c with the additional parameters.
2)
The doc-string for signal.sigwaitinfo was changed since Georg made his patch, and its first line was now too long. I shortened the first line from:
Wait synchronously for a signal until one of the signals in *sigset* is delivered.
to:
Wait synchronously until one of the signals in *sigset* is delivered.
3)
Converted the new sys.is_finalizing function.
4)
Reverted the signal.set_wakeup_fd function, since it has since been changed, and now depending on #ifdef MS_WINDOWS it interprets the argument as either 'O' or 'i'. I'm not sure what to do with this one, so I reverted it back to not use AC for now.
5)
I haven't converted the new signal.default_int_handler function, since it seems to accept any number of arguments, and ignores them. Is there a way to do this with AC?
6)
Moved the definitions of object structs and PyTypeObject types to the top of selectmodule.c, so that they are defined when Modules/clinic/selectmodule.c.h is imported. |
|
Date |
User |
Action |
Args |
2015-04-24 00:00:15 | taleinat | set | recipients:
+ taleinat, loewis, georg.brandl, larry, nadeem.vawda, serhiy.storchaka |
2015-04-24 00:00:14 | taleinat | set | messageid: <1429833614.85.0.122132604463.issue20182@psf.upfronthosting.co.za> |
2015-04-24 00:00:14 | taleinat | link | issue20182 messages |
2015-04-24 00:00:14 | taleinat | create | |
|