This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author maciej.szulik
Recipients jesstess, maciej.szulik, pitrou, r.david.murray, zvyn
Date 2015-04-15.21:58:21
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1429135101.92.0.483634142051.issue22137@psf.upfronthosting.co.za>
In-reply-to
Content
Milan one more thing to change in your patch, in all your TCs you're modifying client state, I mean this part:

# lets cheat a bit here:
client.state = 'SELECTED'

It's OK to do that on the mocked server, but this is not acceptable doing on the tested library. It's better to call client.login() to change the state to 'AUTH' properly and only after that, call the actual method under test.
History
Date User Action Args
2015-04-15 21:58:21maciej.szuliksetrecipients: + maciej.szulik, pitrou, r.david.murray, jesstess, zvyn
2015-04-15 21:58:21maciej.szuliksetmessageid: <1429135101.92.0.483634142051.issue22137@psf.upfronthosting.co.za>
2015-04-15 21:58:21maciej.szuliklinkissue22137 messages
2015-04-15 21:58:21maciej.szulikcreate