This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author neale
Recipients amaury.forgeotdarc, neale
Date 2015-04-01.16:09:29
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <D141863E.238C5%neale@sinenomine.net>
In-reply-to <1427901259.87.0.485174766878.issue23830@psf.upfronthosting.co.za>
Content
Thanks. Question/responses in-line

On 4/1/15, 11:14 AM, "Amaury Forgeot d'Arc" <report@bugs.python.org> wrote:

>
>Amaury Forgeot d'Arc added the comment:
>
>Hi,
>First, please fill and submit a Contribution Agreement:
>https://www.python.org/psf/contrib/
Done but I never got the email confirmation - it was not in my spam fold
either.

>Then about the patch:
>- This is a patch against Python2.7, which is frozen for new
>developments. This change will only be applied to python 3.5 or later.
Understood.

>- There are some tab characters in the diff
Will fix

>- Names are limited to 8 characters, but there is no check.
I truncate, but I will add a check to be more programmer friendly

>- Names must be padded with spaces. This is done automatically in
>connect(), but these extra spaces should be removed in makesockaddr() so
>that the same names are returned.
Will do, I was going to let the caller strip() but I will do it here
instead. Is there an existing strip routine that I could call rather than
writing my own (trivial) stripper?

Do I resubmit the patch in the bug/enhancement report I had created?

Neale
History
Date User Action Args
2015-04-01 16:09:29nealesetrecipients: + neale, amaury.forgeotdarc
2015-04-01 16:09:29nealelinkissue23830 messages
2015-04-01 16:09:29nealecreate