Message237110
Haha, yes, that description and patch look correct. Thanks!
Fortunately this bug is low impact as this was just a sanity check and the calling code from subprocess.py was already passing the correct data in.
An ideal regression test: An explicit unittest that calls the _posixsubprocess API with some bad sequences of values in fds_to_keep and uses assertRaises to check for the appropriate ValueError("bad value(s) in fds_to_keep") coming out of it... |
|
Date |
User |
Action |
Args |
2015-03-03 07:34:45 | gregory.p.smith | set | recipients:
+ gregory.p.smith, Hisham Muhammad |
2015-03-03 07:34:45 | gregory.p.smith | set | messageid: <1425368085.02.0.264448146912.issue23564@psf.upfronthosting.co.za> |
2015-03-03 07:34:44 | gregory.p.smith | link | issue23564 messages |
2015-03-03 07:34:44 | gregory.p.smith | create | |
|