Message235868
> If we leave it as it is, it would be good to add comment in the source code explaining this decision.
I think that __all__ should be left as-is for the time being. Adding
some comments around that decision makes sense to me to avoid any future
confusion around that.
> Also the test case could still be useful to catch future bugs.
Agreed. I've added a couple minor comments to the review.
Thanks for the work on this! |
|
Date |
User |
Action |
Args |
2015-02-13 01:13:27 | demian.brecht | set | recipients:
+ demian.brecht, berker.peksag, martin.panter |
2015-02-13 01:13:27 | demian.brecht | link | issue23439 messages |
2015-02-13 01:13:27 | demian.brecht | create | |
|