Message235093
Maybe you don’t want to touch the implementation of the “older high-level API” for fear of subtly breaking something, but for clarification, and perhaps documentation, would the old functions now be equivalent to this?
def call(***):
# Verify PIPE not in (stdout, stderr) if needed
return run(***).returncode
def check_call(***):
# Verify PIPE not in (stdout, stderr) if needed
run(***, check=True)
def check_output(***):
# Verify stderr != PIPE if needed
return run(***, check=True, stdout=PIPE)
If they are largely equivalent, perhaps simplify the documentation of them in terms of run(), and move them closer to the run() documentation.
Is it worth making the CalledProcessError exception a subclass of CompletedProcess? They seem to be basically storing the same information. |
|
Date |
User |
Action |
Args |
2015-01-31 09:46:33 | martin.panter | set | recipients:
+ martin.panter, barry, gregory.p.smith, r.david.murray, ethan.furman, takluyver |
2015-01-31 09:46:32 | martin.panter | set | messageid: <1422697592.93.0.0739211581788.issue23342@psf.upfronthosting.co.za> |
2015-01-31 09:46:32 | martin.panter | link | issue23342 messages |
2015-01-31 09:46:32 | martin.panter | create | |
|