This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author vstinner
Recipients gvanrossum, vstinner, yselivanov
Date 2015-01-14.23:11:18
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1421277078.82.0.431621848437.issue23242@psf.upfronthosting.co.za>
In-reply-to
Content
The asyncio.subprocess.Process class never closes the subprocess transport, whereas this transport is private.

I propose to close the transport as soon as possible: when transport.get_returncode() is called and its result is not None.

I'm not sure that it's the most efficient way to close the transport. It may be better to close the transport in the connection_lost() method of the protocol.

The patch also checks in Process.communicate() that the process is alive, and is clears the reference to the transport.
History
Date User Action Args
2015-01-14 23:11:18vstinnersetrecipients: + vstinner, gvanrossum, yselivanov
2015-01-14 23:11:18vstinnersetmessageid: <1421277078.82.0.431621848437.issue23242@psf.upfronthosting.co.za>
2015-01-14 23:11:18vstinnerlinkissue23242 messages
2015-01-14 23:11:18vstinnercreate