Message 233639 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	vstinner
Recipients	benjamin.peterson, hynek, josh.r, pitrou, steve.dower, stutzbach, tim.golden, vstinner, zach.ware
Date	2015-01-08.10:34:16
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1420713256.98.0.309029839742.issue23152@psf.upfronthosting.co.za>
In-reply-to

Content
> #define fstat _fstati64 This change (alone) is not safe because _fstati64() doesn't use "struct stat" but "struct __stat64". I don't like such global define, I may have unexpected side effect. I prefer to modify directly calls to fstat() in .c files (like the change implemented in my patch).

> #define fstat _fstati64

This change (alone) is not safe because _fstati64() doesn't use "struct stat" but "struct __stat64".

I don't like such global define, I may have unexpected side effect. I prefer to modify directly calls to fstat() in .c files (like the change implemented in my patch).

History
Date	User	Action	Args
2015-01-08 10:34:17	vstinner	set	recipients: + vstinner, pitrou, tim.golden, benjamin.peterson, stutzbach, hynek, zach.ware, steve.dower, josh.r
2015-01-08 10:34:16	vstinner	set	messageid: <1420713256.98.0.309029839742.issue23152@psf.upfronthosting.co.za>
2015-01-08 10:34:16	vstinner	link	issue23152 messages
2015-01-08 10:34:16	vstinner	create