➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author rhettinger
Recipients ezio.melotti, gvanrossum, mrabarnett, pitrou, rhettinger, serhiy.storchaka, terry.reedy
Date 2014-11-09.02:52:25
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1415501546.92.0.728532376224.issue22434@psf.upfronthosting.co.za>
In-reply-to
Content 
I reviewed re_named_consts.patch and it looks great (I especially like the removal of superfluous OPCODES dictionary lookups and improved repr for the integer codes).

Since the op codes are singletons, you can use identity tests instead of 
equality checks in sre_parse.py:

  -      if op == "in":
  +      if op == IN:

Also, I'll echo the suggestion to make NamedIntConstant private with a leading underscore.

Nice work.
History
Date User Action Args
2014-11-09 02:52:27rhettingersetrecipients: + rhettinger, gvanrossum, terry.reedy, pitrou, ezio.melotti, mrabarnett, serhiy.storchaka
2014-11-09 02:52:26rhettingersetmessageid: <1415501546.92.0.728532376224.issue22434@psf.upfronthosting.co.za>
2014-11-09 02:52:26rhettingerlinkissue22434 messages
2014-11-09 02:52:26rhettingercreate