Message227659
Antony, I agree regarding the poor naming of '_sanitize_dir()' helper. As for your other suggestion, I think such a refactoring will actually make code harder to follow (+ it's more invasive). Generally, I'm in favour of transforming parameters like 'dir' closer to the beginning of the method's code, so that it's immediately obvious what's going on, and is also easier to put debug code [like 'print("mkdtemp call for: ", dir)']. |
|
Date |
User |
Action |
Args |
2014-09-26 21:54:18 | yselivanov | set | recipients:
+ yselivanov, georg.brandl, ncoghlan, serhiy.storchaka, Antony.Lee |
2014-09-26 21:54:18 | yselivanov | set | messageid: <1411768458.65.0.210867949919.issue20267@psf.upfronthosting.co.za> |
2014-09-26 21:54:18 | yselivanov | link | issue20267 messages |
2014-09-26 21:54:18 | yselivanov | create | |
|