This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author vstinner
Recipients David.Edelsohn, pitrou, serhiy.storchaka, vstinner
Date 2014-09-23.13:32:57
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1411479177.58.0.220430355627.issue22396@psf.upfronthosting.co.za>
In-reply-to
Content
> Attached is a revised patch that disables posix_fadvise() and posix_fallocate() when building on 32 bit AIX with _LARGE_FILES defined.

Good. You should add a reference to this issue, something like "Issue #22396: ...".

To avoid code duplication, you may write something like:

/* Issue #22396: AIX currently does not support a 32-bit 
   call to posix_fallocate() if _LARGE_FILES is defined. */
#if defined(HAVE_POSIX_FALLOCATE) && !(defined(_AIX) && defined(_LARGE_FILES) && !defined(__64BIT__))
#  undef HAVE_POSIX_FALLOCATE
#endif

or "#define BROKEN_POSIX_FALLOCATE".

Which Python versions should be patched? 3.4 and 3.5? Python 2.7 doesn't have the function (introduced in Python 3.3). For Python 3.4, it means that between two Python minor versions, the function disappears on AIX 32-bit :-/ Is it a problem since the function didn't work on this platform? (always fail with EINVAL)

I suggest to patch 3.4 and 3.5.
History
Date User Action Args
2014-09-23 13:32:57vstinnersetrecipients: + vstinner, pitrou, serhiy.storchaka, David.Edelsohn
2014-09-23 13:32:57vstinnersetmessageid: <1411479177.58.0.220430355627.issue22396@psf.upfronthosting.co.za>
2014-09-23 13:32:57vstinnerlinkissue22396 messages
2014-09-23 13:32:57vstinnercreate