Message226809
re_octal_escape_overflow_raise.patch: you should write a subfunction to not repeat the error message 3 times.
+ if c > 0o377:
Hum, I never use octal. 255 instead of 0o377 would be less surprising :-p By the way, you should also check for negative numbers.
>>> -3 & 0xff
253
Before, "& 0xff" also converted negative numbers to positive in range 0..255. |
|
Date |
User |
Action |
Args |
2014-09-12 07:36:30 | vstinner | set | recipients:
+ vstinner, pitrou, ezio.melotti, mrabarnett, serhiy.storchaka |
2014-09-12 07:36:30 | vstinner | set | messageid: <1410507390.05.0.545596204151.issue22362@psf.upfronthosting.co.za> |
2014-09-12 07:36:30 | vstinner | link | issue22362 messages |
2014-09-12 07:36:29 | vstinner | create | |
|