Message22266
Logged In: YES
user_id=21627
The patch looks good. It doesn't need to be complete, but it
should be correct for the APIs which it does change. A few
comments:
- there is probably little point in changing getaddrinfo.c.
This is an emulation that is only used on systems which
don't have a "proper" getaddrinfo, and most likely, all
systems offering gethostbyname_r also offer getaddrinfo.
- the usage of readdir_r is incorrect - you need to provide
for sufficient space.
- I don't think it is good to allocate 8k on the stack.
Instead, you should indeed start with a small buffer, then
grow it as needed, using malloc. |
|
Date |
User |
Action |
Args |
2007-08-23 14:25:51 | admin | link | issue1018492 messages |
2007-08-23 14:25:51 | admin | create | |
|