➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author rhettinger
Recipients Lita.Cho, jesstess, rhettinger
Date 2014-06-22.07:54:42
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1403423683.29.0.660317083352.issue21812@psf.upfronthosting.co.za>
In-reply-to
Content 
The looks good.  Please revise the patch to isolate the actual change in logic and not confound it with PEP-8 nits which make the patch harder to review.

Also, please be careful with breaking lines.  In the following part of the diff, the space after "matrix:" is lost (Hazards like this are one reason to avoid cosmetic changes).

-            raise TurtleGraphicsError("Bad shape transform matrix: must not be singular")
+            raise TurtleGraphicsError(("Bad shape transform matrix:"
+                                       "must not be singular")
History
Date User Action Args
2014-06-22 08:05:30rhettingerunlinkissue21812 messages
2014-06-22 07:54:43rhettingersetrecipients: + rhettinger, jesstess, Lita.Cho
2014-06-22 07:54:43rhettingersetmessageid: <1403423683.29.0.660317083352.issue21812@psf.upfronthosting.co.za>
2014-06-22 07:54:43rhettingerlinkissue21812 messages
2014-06-22 07:54:42rhettingercreate