➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author giampaolo.rodola
Recipients ethan.furman, giampaolo.rodola, gvanrossum, neologix, vstinner
Date 2014-03-28.12:52:09
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1396011129.61.0.630761055002.issue21076@psf.upfronthosting.co.za>
In-reply-to
Content 
(replying here 'cause rietveld keeps giving me an exception when I submit a reply)

On 2014/03/28 00:49:47, haypo wrote:
> http://bugs.python.org/review/21076/diff/11457/Lib/signal.py
> File Lib/signal.py (right):
> 
> http://bugs.python.org/review/21076/diff/11457/Lib/signal.py#newcode7
> Lib/signal.py:7: if name.isupper()
> You can probably remove this test.
> 
> http://bugs.python.org/review/21076/diff/11457/Lib/signal.py#newcode8
> Lib/signal.py:8: and (name.startswith('SIG') and not name.startswith('SIG_'))
> Why do you ignore SIG_DFL, SIG_IGN, SIG_BLOCK, SIG_UNBLOCK, SIG_SETMASK? It may
> also be interesting to provide enums for them. They are just integers (0, 1 or
> 2) on my Linux.

I guess it makes sense.
I'm now realizing that the patch as-is is incomplete as the other "get" APIs (signal.getsignal() and others) still return integers: they should be overridden in order to convert integers into enums, similarly to http://hg.python.org/cpython/file/d8659dbebfd1/Lib/socket.py#l262
I will do that.
History
Date User Action Args
2014-03-28 12:52:09giampaolo.rodolasetrecipients: + giampaolo.rodola, gvanrossum, vstinner, neologix, ethan.furman
2014-03-28 12:52:09giampaolo.rodolasetmessageid: <1396011129.61.0.630761055002.issue21076@psf.upfronthosting.co.za>
2014-03-28 12:52:09giampaolo.rodolalinkissue21076 messages
2014-03-28 12:52:09giampaolo.rodolacreate