Message214143
A Python test that reproduces this would be nice to have though I realize it isn't something necessarily useful to run as part of a unittest suite given this one would rely on OS kernel implementation details and chances of race conditions occurring.
Regardless I agree with the general comments. This code could be improved with better error handling given the poor APIs for getting a list of open file descriptors that we have to work with.
It should be much less of an issue in 3.4 and later due to the O_CLOEXEC default via http://legacy.python.org/dev/peps/pep-0446/ but the posixsubprocess code should be updated to handle the errors better there regardless. |
|
Date |
User |
Action |
Args |
2014-03-19 23:09:08 | gregory.p.smith | set | recipients:
+ gregory.p.smith, socketpair |
2014-03-19 23:09:08 | gregory.p.smith | set | messageid: <1395270548.87.0.771366619988.issue20979@psf.upfronthosting.co.za> |
2014-03-19 23:09:08 | gregory.p.smith | link | issue20979 messages |
2014-03-19 23:09:08 | gregory.p.smith | create | |
|