Message209984
> I think Raymond's original concern still applies: The macros do add to the learning curve.
I agree. But alternative solution is Victor's original patch which replaces potential bugs by inlined body of Py_REPLACE/Py_XREPLACE. This is explicit, but more verbose (2 lines are replaced by 5 lines with one new variable, with macros it would be one line), less clear and more errorprone.
I believe that given the popularity of such a code and the possibility of mistakes, it is worth introducing special macros. Here apply the same reasoning as for Py_CLEAR.
Of course these macros shouldn't be a part of stable API in 2.7 and 3.3 (and may be even in 3.4). |
|
Date |
User |
Action |
Args |
2014-02-02 13:53:28 | serhiy.storchaka | set | recipients:
+ serhiy.storchaka, loewis, brett.cannon, georg.brandl, rhettinger, pitrou, vstinner, larry, benjamin.peterson, skrah |
2014-02-02 13:53:28 | serhiy.storchaka | set | messageid: <1391349208.63.0.515963951654.issue20440@psf.upfronthosting.co.za> |
2014-02-02 13:53:28 | serhiy.storchaka | link | issue20440 messages |
2014-02-02 13:53:28 | serhiy.storchaka | create | |
|