This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author vajrasky
Recipients benjamin.peterson, berker.peksag, ezio.melotti, lars.gustaebel, lemburg, pitrou, serhiy.storchaka, vajrasky, vstinner
Date 2014-01-22.04:47:57
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1390366078.53.0.380056126365.issue19920@psf.upfronthosting.co.za>
In-reply-to
Content
Here is the patch addressing some of Serhiys concerns. Thanks for the review.

There are some things that I could not make it up:
1. The test for unencodable tarinfo.linkname is not done yet, because maybe it is better to be done in a separate ticket. To make the test simple, we need to modify the testtar.tar file. We need to add file with unencodable linkname. Is it too much to do it in this ticket?

2. "should exist separate test (not in CommandLineTest) for the TarFile.list() method itself." -> I haven't got the inspiration yet how to create this test to add additional value.
History
Date User Action Args
2014-01-22 04:47:58vajraskysetrecipients: + vajrasky, lemburg, lars.gustaebel, pitrou, vstinner, benjamin.peterson, ezio.melotti, berker.peksag, serhiy.storchaka
2014-01-22 04:47:58vajraskysetmessageid: <1390366078.53.0.380056126365.issue19920@psf.upfronthosting.co.za>
2014-01-22 04:47:58vajraskylinkissue19920 messages
2014-01-22 04:47:58vajraskycreate