This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author r.david.murray
Recipients brett.cannon, eric.snow, larry, ncoghlan, r.david.murray, vstinner
Date 2014-01-05.02:47:41
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1388890062.43.0.165835361979.issue20123@psf.upfronthosting.co.za>
In-reply-to
Content
In 2.7 the code just does an open.  Victor changed it to call tokenize.open in 3.2, but tokenize.open obviously only works on python source files.  So the logic of that method is now completely wrong.

I'm not sure the logic made a lot of sense even before...if the extension is binary it just closes it again.  So the initial open is for its side effect of returning None if the file can't be opened.

Anyway, the logic of that method clearly needs to be rewritten.  And obviously there are some missing tests....

I don't see any patch attached to the issue, by the way.
History
Date User Action Args
2014-01-05 02:47:42r.david.murraysetrecipients: + r.david.murray, brett.cannon, ncoghlan, vstinner, larry, eric.snow
2014-01-05 02:47:42r.david.murraysetmessageid: <1388890062.43.0.165835361979.issue20123@psf.upfronthosting.co.za>
2014-01-05 02:47:42r.david.murraylinkissue20123 messages
2014-01-05 02:47:41r.david.murraycreate