Message204898
In those protocols where client and server exchange a lot of commands and responses in a single session, such as FTP, modify() is going to be called many times.
I don't have actual numbers but I remember that using epoll.modify() was one of those relatively small optimizations which all put together led to current pyftpdlib performances. For poll() and epoll() pollers I see no reason not to use the specialized modify().
That aside, what actually *does* make a big difference and it is very important is to "unregister" a fd for writing (EVENT_WRITE) when there's no more data to send, and that's something that should be done at a higher level (transport.write() and anywhere else some data is sent). |
|
Date |
User |
Action |
Args |
2013-12-01 09:43:12 | giampaolo.rodola | set | recipients:
+ giampaolo.rodola, gvanrossum, pitrou, vstinner, neologix |
2013-12-01 09:43:12 | giampaolo.rodola | set | messageid: <1385890992.12.0.810153878305.issue19842@psf.upfronthosting.co.za> |
2013-12-01 09:43:12 | giampaolo.rodola | link | issue19842 messages |
2013-12-01 09:43:11 | giampaolo.rodola | create | |
|