➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author serhiy.storchaka
Recipients doerwalter, ezio.melotti, lemburg, ncoghlan, serhiy.storchaka, vstinner
Date 2013-11-21.16:44:34
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1385052274.24.0.012871903061.issue19619@psf.upfronthosting.co.za>
In-reply-to
Content 
Why

    return codecs.CodecInfo._declare_transform(
        name='base64',
        encode=base64_encode,
        decode=base64_decode,
        incrementalencoder=IncrementalEncoder,
        incrementaldecoder=IncrementalDecoder,
        streamwriter=StreamWriter,
        streamreader=StreamReader,
    )

instead of

    codec = codecs.CodecInfo(
        name='base64',
        encode=base64_encode,
        decode=base64_decode,
        incrementalencoder=IncrementalEncoder,
        incrementaldecoder=IncrementalDecoder,
        streamwriter=StreamWriter,
        streamreader=StreamReader,
    )
    codec._is_text_encoding = False
    return codec

?

I have added other minor comments on Rietveld.
History
Date User Action Args
2013-11-21 16:44:34serhiy.storchakasetrecipients: + serhiy.storchaka, lemburg, doerwalter, ncoghlan, vstinner, ezio.melotti
2013-11-21 16:44:34serhiy.storchakasetmessageid: <1385052274.24.0.012871903061.issue19619@psf.upfronthosting.co.za>
2013-11-21 16:44:34serhiy.storchakalinkissue19619 messages
2013-11-21 16:44:34serhiy.storchakacreate