➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author benjamin.peterson
Recipients benjamin.peterson, serhiy.storchaka, vstinner
Date 2013-11-18.13:18:31
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <CAPZV6o-BsngN113L=-Xba=pMkbX7uMfA2qkEwK_w4TUQ4FWWZw@mail.gmail.com>
In-reply-to <1384766055.62.0.133518488825.issue19617@psf.upfronthosting.co.za>
Content 
I meant where you added casts, you could use it.

2013/11/18 STINNER Victor <report@bugs.python.org>:
>
> STINNER Victor added the comment:
>
>> You could use the Py_SAFE_DOWNCAST macro everywhere.
>
> I prefer to store sizes in a size type (Py_ssize_t), and only downcast where it is really needed, in compiler_addop_i(). So in the future, if someone wants to support values larger than INT_MAX, only one function need to be changed.
>
> ----------
>
> _______________________________________
> Python tracker <report@bugs.python.org>
> <http://bugs.python.org/issue19617>
> _______________________________________
History
Date User Action Args
2013-11-18 13:18:31benjamin.petersonsetrecipients: + benjamin.peterson, vstinner, serhiy.storchaka
2013-11-18 13:18:31benjamin.petersonlinkissue19617 messages
2013-11-18 13:18:31benjamin.petersoncreate