➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author pitrou
Recipients christian.heimes, gregory.p.smith, pitrou, python-dev, rhettinger
Date 2013-11-17.14:24:04
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1384698245.19.0.1313293.issue18742@psf.upfronthosting.co.za>
In-reply-to
Content 
Some comments:
- AbstractCryptoHashFunction should be called CryptoHashBase or something (but does it warrant being public? I don't think so)
- having "Function" in a class name is a bit confusing to me. Why not simply "CryptoHash"?
- you don't need to add a __slots__ to your ABCs, IMO
- the default hexdigest() implementation looks a bit suboptimal to me, why not use binascii?
History
Date User Action Args
2013-11-17 14:24:05pitrousetrecipients: + pitrou, rhettinger, gregory.p.smith, christian.heimes, python-dev
2013-11-17 14:24:05pitrousetmessageid: <1384698245.19.0.1313293.issue18742@psf.upfronthosting.co.za>
2013-11-17 14:24:05pitroulinkissue18742 messages
2013-11-17 14:24:04pitroucreate