Message203107
The assertions have their arguments in the wrong order, it should be (actual, expected).
In the code of the module there are also some examples in the comments, e.g.:
# path is something like ////host/path/on/remote/host
# convert this to \\host\path\on\remote\host
Even though the path is covered, there's no similar test in this patch.
I would suggest you to include all the examples from the module in the tests.
Also note that this module is already indirectly tested in test_urllib. |
|
Date |
User |
Action |
Args |
2013-11-16 23:45:11 | ezio.melotti | set | recipients:
+ ezio.melotti, orsenthil, Colin.Williams |
2013-11-16 23:45:11 | ezio.melotti | set | messageid: <1384645511.61.0.983575275112.issue19383@psf.upfronthosting.co.za> |
2013-11-16 23:45:11 | ezio.melotti | link | issue19383 messages |
2013-11-16 23:45:11 | ezio.melotti | create | |
|